Conversation
|
GNU testsuite comparison: |
Contributor
|
some jobs are failing |
oech3
force-pushed
the
lscolh
branch
2 times, most recently
from
a5e44a1 to
9c1d041
Compare
This comment was marked as resolved.
This comment was marked as resolved.
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
Contributor
Author
|
Really 0% perf change. Just for binary size. |
Contributor
do you have the numbers ? |
Contributor
Author
|
stripped, current --release: 2172960 -> 2171200 |
sylvestre
reviewed
Feb 5, 2026
| // It's possible a simple vector linear(binary?) search implementation would be even faster. | ||
| #[cfg(unix)] | ||
| uid_cache: FxHashMap<u32, String>, | ||
| uid_cache: HashMap<u32, String>, |
Contributor
Author
There was a problem hiding this comment.
Yes. Because I took shadowing approach
use rustc_hash::FxHashMap as HashMap;
use rustc_hash::FxHashSet as HashSet;
for the case we swap it in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.